Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract radio-button and radio-group logic to mixins #6680

Merged
merged 1 commit into from
Oct 20, 2023
Merged

refactor: extract radio-button and radio-group logic to mixins #6680

merged 1 commit into from
Oct 20, 2023

Conversation

web-padawan
Copy link
Member

Description

Extracted vaadin-radio-button and vaadin-radio-group logic into mixins for using by Lit version.

Type of change

  • Refactor

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.0% 6.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@web-padawan web-padawan merged commit c1d2e1f into main Oct 20, 2023
@web-padawan web-padawan deleted the refactor/radio-group-mixin branch October 20, 2023 12:08
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.3.0 Released with Vaadin 24.3.0.alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @tomivirkki