Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace flattened nodes observer with grid column observer #6686

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 23, 2023

Description

Replace the Polymer helper FlattenedNodesObserver in <vaadin-grid> with a built-in ColumnObserver helper.

Type of change

Refactor

@tomivirkki tomivirkki marked this pull request as draft October 23, 2023 14:21
@tomivirkki tomivirkki marked this pull request as ready for review October 24, 2023 07:48
packages/grid/test/column-observer.test.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants