Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract accordion and accordion-panel mixins #6975

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

web-padawan
Copy link
Member

Description

Extracted reusable mixin for vaadin-accordion and vaadin-accordion-panel to be used by LitElement version.

Type of change

  • Refactor

@web-padawan web-padawan force-pushed the refactor/accordion-mixins branch 2 times, most recently from ba814a0 to 7d4cabc Compare December 15, 2023 11:51
@web-padawan web-padawan force-pushed the refactor/accordion-mixins branch from 7d4cabc to a5c520a Compare December 15, 2023 11:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

18.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but should this PR also include split <vaadin-accordion-heading>?

@web-padawan
Copy link
Member Author

lgtm, but should this PR also include split ?

This component only has opened property and ready() method so I though it's small enough to copy.

@web-padawan web-padawan merged commit 1328bad into main Dec 15, 2023
8 of 9 checks passed
@web-padawan web-padawan deleted the refactor/accordion-mixins branch December 15, 2023 13:45
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants