Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop propagation of click events on overlay (#6987) #6995

Merged

Conversation

ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Dec 21, 2023

Description

Back-port of #6987 to v23.4 and v23.3.

The test has 2 extra functions since the helper class does not exist in v23.

Fixes #6986

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

* fix: stop propagation of click events on overlay

* test: remove added test and add integration test instead
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ugur-vaadin ugur-vaadin removed the request for review from DiegoCardoso December 21, 2023 08:07
@ugur-vaadin ugur-vaadin merged commit 56daef3 into 23.4 Dec 21, 2023
10 checks passed
@ugur-vaadin ugur-vaadin deleted the fix-stop-propagation-of-click-events-on-overlay-v23 branch December 21, 2023 08:07
vaadin-bot pushed a commit that referenced this pull request Dec 21, 2023
* fix: stop propagation of click events on overlay

* test: remove added test and add integration test instead
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.4.0.alpha2 and is also targeting the upcoming stable 23.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants