refactor: remove not working logic, reorganize focus tests #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Feb 23, 2024
vursen
reviewed
Feb 23, 2024
vursen
approved these changes
Feb 23, 2024
Co-authored-by: Sergey Vinogradov <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #4148, currently the logic for restoring focus-ring does not work as expected so it can be removed.
The only case for this logic is outside click. On item click, Esc or Enter key the
<input>doesn't lose focus.The logic was added in vaadin/vaadin-combo-box#599. However, latest V14 version also seems to have the issue.
Note: I quickly tried to apply the fix for a similar issue in the
vaadin-date-picker- #4341. However, it causes a bunch of tests to fail, apparently due to validation not run on outside click with that approach (or maybe I just got it wrong).For now, the test about outside click contains
FIXMEwith a commented line, to be fixed later.Type of change