fix: revert input on overlay close by escape #7293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
commented
Apr 3, 2024
| return date.toISOString().split('T')[0]; | ||
| } | ||
|
|
||
| const TODAY_DATE = formatDateISO(new Date()); |
There was a problem hiding this comment.
These changes are not actually related to the issue. This formatting does not take time zones into consideration. This leads to tests failing when time zone is not GMT.
There was a problem hiding this comment.
I think we could extract this change into separate PR marked as test: and maybe backport to 24.3.
There was a problem hiding this comment.
Extracted the test PR and reverted the changes in this one.
ugur-vaadin
commented
Apr 3, 2024
| @@ -1,19 +1,12 @@ | |||
| import { expect } from '@esm-bundle/chai'; | |||
| import { aTimeout, fixtureSync, nextRender, outsideClick, tap } from '@vaadin/testing-helpers'; | |||
ugur-vaadin
changed the title
ugur-vaadin
changed the title
ugur-vaadin
changed the title
9 tasks
|
web-padawan
approved these changes
Apr 8, 2024
ugur-vaadin
deleted the
fix-revert-input-and-do-not-commit-on-overlay-escape
branch
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
* fix: revert input and do not commit on overlay escape * refactor: commit the reverted date so that the validation cycle runs * test: revert test update for unparsable value change event * test: revert test formatter changes
web-padawan
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: Ugur Saglam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when
escapethe input is not reverted and the date picker is validated using the unparsable input.
This PR reverts the input value to the last selected date if the overlay is closed using
escape.!!! This fix was tested with the Flow counterpart. However, if any regressions occur regarding the validation chain, this PR can be the culprit. !!!
Fixes #4354
Type of change
Checklist