-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: blur active element on step buttons touchend #7512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
approved these changes
Jul 5, 2024
DiegoCardoso
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
sissbruecker
pushed a commit
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
sissbruecker
pushed a commit
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version. |
This was referenced Aug 29, 2024
Closed
Closed
Merged
Merged
This was referenced Aug 31, 2024
Closed
Closed
Closed
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7494
Adapted the code from #7494 (comment). One notable change is using
getDeepActiveElement()
helper instead ofdocument.activeElement
to ensure field's own<input>
doesn't get blurred when the field is in shadow root.Type of change