Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve large items when new items are added (#7987) (CP: 24.4) #8001

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ugur-vaadin
Copy link
Contributor

Description

Back-port of # (7987)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

* fix: preserve large items when new items are added

* fix: fix refactor typo

* test: extract initialization with large item count
Copy link

@ugur-vaadin ugur-vaadin marked this pull request as ready for review October 21, 2024 07:23
@ugur-vaadin ugur-vaadin removed the request for review from sissbruecker October 21, 2024 11:27
@ugur-vaadin ugur-vaadin merged commit 538d48a into 24.4 Oct 21, 2024
9 checks passed
@ugur-vaadin ugur-vaadin deleted the fix-virtualizer-preserve-large-items-24-4 branch October 21, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants