fix: prevent duplicate warn up when opening same tooltip twice #8135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Nov 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
* fix: prevent duplicate warn up when opening same tooltip twice * test: reset global state in afterEach to make tests reliable * fix: also clear timeout references when resetting global state * test: change the tooltip opened check back to false * refactor: simplify tooltip warm up condition logic
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
* fix: prevent duplicate warn up when opening same tooltip twice * test: reset global state in afterEach to make tests reliable * fix: also clear timeout references when resetting global state * test: change the tooltip opened check back to false * refactor: simplify tooltip warm up condition logic
web-padawan
added a commit
that referenced
this pull request
Nov 12, 2024
#8139) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Nov 12, 2024
#8140) Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #8131
This fixes another edge-case when reusing the same
vaadin-tooltipinstance and callingopen()twice: currently, warm up is scheduled twice with twosetTimeout()calls and only the second one is stored in a variable (and then canceled).From now on we check if there is an ongoing warm up timeout and if so, do not schedule another one unnecessarily.
Type of change