refactor: include notification container into the overlay stack #8198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Nov 21, 2024
tomivirkki
approved these changes
Nov 21, 2024
|
|
The Firefox test is unrelated to the PR, I'm going to merge without requiring checks to pass. |
web-padawan
added a commit
that referenced
this pull request
Nov 21, 2024
web-padawan
added a commit
that referenced
this pull request
Nov 21, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#6836
This is an alternative fix to #8193 as suggested in #8193 (comment)
Adding notification container to the common overlay stack resolves also the issue similar to the one reported in #5748 but for
vaadin-popoverand other overlays that can be technically triggered from buttons inside thevaadin-notification.Type of change
Note
We also have
_enterModalState()method in theOverlayStackMixin- this method isn't called in case of notification container, so that it's still possible to interact with underlyingvaadin-dialogwhen the notification is opened from it.