fix: force scroller update after revealing a date #8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
force-update-after-scrolling-to-dates
branch
2 times, most recently
from
0595c78 to
03dda97
Compare
vursen
force-pushed
the
force-update-after-scrolling-to-dates
branch
from
03dda97 to
f933665
Compare
|
vursen
commented
Nov 22, 2024
| /** | ||
| * @param {HTMLElement} root vaadin-date-picker or vaadin-date-picker-overlay-content | ||
| */ | ||
| export function getFocusableCell(root) { |
There was a problem hiding this comment.
note: Having the focused part doesn't always mean that the cell is actually focused. I decided to split this helper into getFocusableCell and getFocusedCell for clarity.
vursen
commented
Nov 22, 2024
| */ | ||
| export async function waitForScrollToFinish(overlayContent) { | ||
| export async function waitForScrollToFinish(root) { |
There was a problem hiding this comment.
note: I also changed the signature of these methods to allow tests to pass datePicker instead of datePicker._overlayContent which slightly more convenient.
web-padawan
approved these changes
Nov 22, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
vursen
added a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Sergey Vinogradov <[email protected]>
vursen
added a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Sergey Vinogradov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out essential to flush all scroller debouncers before trying to focus any date to ensure the DOM is updated and the date is truly focusable. Previously,
date.focus()could be called before the scrolled appliedtabindex=0to the date element, and this led to test failures because not all browsers allow focusing elements withtabindex=-1.Part of #8187
Type of change