refactor: ensure disabled buttons suppress interaction events #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vursen
force-pushed
the
suppress-interaction-events-when-disabled
branch
from
141ddfc to
597d3f1
Compare
|
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
sissbruecker
approved these changes
Jan 21, 2025
|
This ticket/PR has been released with Vaadin 24.7.0.alpha6 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR ensures that interaction events like
click,mousedown, etc. are suppressed on disabled buttons even whenpointer-eventsis set toauto.This change revealed an issue with a CRUD test. When running this test with the Lit version in WebKit or Safari, the save button remains disabled for some reason after the click event. Previously, it was passing by mistake. I've decided to temporarily skip this test, as the cause remained unclear even after several hours of debugging:
web-components/packages/crud/src/vaadin-crud-mixin.js
Line 693 in 8463c9f
Part of #4585
Type of change