Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add sendMouseToElement test runner command #8566

Merged
merged 12 commits into from
Feb 3, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 27, 2025

Description

Adds a new test runner command, sendMouseToElement, which builds on sendMouse and allows moving the mouse to an element using its reference rather than its position, whose calculation can be tedious.

Depends on

Type of change

  • Internal

@vursen vursen force-pushed the emulate-hover-command branch from 025b2ba to 1b6981e Compare January 27, 2025 08:00
@vursen vursen force-pushed the vaadin-test-runner-commands branch from fafe422 to 3231f64 Compare January 27, 2025 08:38
@vursen vursen force-pushed the emulate-hover-command branch from 1b6981e to 2c3d93e Compare January 27, 2025 08:39
@vursen vursen changed the title test: extend sendMouse to support element property test: add sendMouseToElement test runner command Jan 27, 2025
@vursen vursen marked this pull request as ready for review January 27, 2025 09:04
Base automatically changed from vaadin-test-runner-commands to main January 27, 2025 13:50
package.json Outdated Show resolved Hide resolved
@vursen vursen force-pushed the emulate-hover-command branch from 57446f0 to 2ae29b1 Compare January 31, 2025 11:31
@vursen vursen force-pushed the emulate-hover-command branch from 2ae29b1 to 7caf099 Compare January 31, 2025 11:32
@vursen vursen requested a review from sissbruecker January 31, 2025 14:39
@web-padawan web-padawan merged commit f6394f0 into main Feb 3, 2025
9 checks passed
@web-padawan web-padawan deleted the emulate-hover-command branch February 3, 2025 08:59
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @web-padawan, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick f6394f0
error: could not apply f6394f0... test: add sendMouseToElement test runner command (#8566)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @vursen and @web-padawan, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick f6394f0
error: could not apply f6394f0... test: add sendMouseToElement test runner command (#8566)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha7 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants