Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: import files that register styles before custom elements #8578

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

web-padawan
Copy link
Member

Description

This fixes the following warnings in visual tests after converting field-highlighter package to Lit:

      The custom element definition for "vaadin-user-tags-overlay" was finalized before a style module was registered. Ideally, import component specific style modules before importing the corresponding custom element. This warning can be suppressed by setting "window.Vaadin.suppressPostFinalizeStylesWarning = true".
      The custom element definition for "vaadin-user-tag" was finalized before a style module was registered. Ideally, import component specific style modules before importing the corresponding custom element. This warning can be suppressed by setting "window.Vaadin.suppressPostFinalizeStylesWarning = true".

Updated other visual tests to make sure common.js and not-animated-styles.js get imported before the component.

Type of change

  • Test

@web-padawan web-padawan requested a review from vursen January 28, 2025 13:20
@web-padawan web-padawan force-pushed the test/fix-visual-imports-order branch from e74cb34 to 992d9ef Compare January 28, 2025 13:41
@web-padawan web-padawan merged commit 3eef437 into main Jan 28, 2025
9 checks passed
@web-padawan web-padawan deleted the test/fix-visual-imports-order branch January 28, 2025 13:49
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha7 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants