Memoized useActions #938
Merged
Memoized useActions #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2021
xdzurman
approved these changes
Apr 8, 2021
* replace unnecessary `useRef` in delegatePage
izri16
force-pushed
the
memoized-use-actions
branch
from
9389cde to
9468513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
useActionsis not memoized which means that every re-render of a component that uses it creates whole new actions. This leads to infinite cycle when actions are used as dependencies inuseEffect.With this change component should get new actions only once when it uses
useActions, however every component that usesuseActionsstill gets new actions object (I will also try to improve that, maybe in another PR)This would need some testing of the core functionality whether nothing got broken (but I guess that cypress tests could do it 🥳 )