Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: value counts on added/concatenated strings #908

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fix: value counts on added/concatenated strings #908

merged 2 commits into from
Sep 24, 2020

Conversation

JovanVeljanoski
Copy link
Member

@JovanVeljanoski JovanVeljanoski commented Jul 17, 2020 •
edited by maartenbreddels
Loading

This PR handles the issue of doing value counts on a virtual column which is created by adding or concatenating strings.

  • Reproducing via a unit-test
  • Make test pass

@maartenbreddels
Copy link
Member

Note to future self: rebase after we merge #885

@maartenbreddels
Copy link
Member

CI failures are unrelated.

@maartenbreddels maartenbreddels merged commit 90aeccd into master Sep 24, 2020
@maartenbreddels maartenbreddels deleted the fix_value_counts_str branch September 24, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maartenbreddels maartenbreddels

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JovanVeljanoski @maartenbreddels