Criterion to divan #622
Merged
Criterion to divan #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rj00a
approved these changes
Jun 19, 2024
|
Should be good once conflicts are fixed. |
I can't fix those (not admin) I suggest you just accept mine for all conflicts as the conflicts are only in the benchmark files which are completely changed anyway. |
|
Your branch is 5 commits behind the main branch. If you rebase or merge you can resolve the conflicts locally. |
|
Ok will do.
|
JackCrumpLeys
force-pushed
the
criterion_to_divan
branch
from
427000e to
f06f587
Compare
|
Well apparently main branch has failing CI so it is not my fault. |
|
Yeah don't worry about CI for now. Thanks. |
made clippy happy in #623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #620.