Drop unused CHANGELOG validation script, straggling NodeJS references. #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes a CI regression in a prior commit (see below) that dropped support for NodeJS libvalhalla bindings, but then called the CHANGELOG validation script using the wrong Node binary. For the moment, we drop this script entirely which is currently a no-op (we're not using 'unreleased' as a section header). - Drops Node bindings CMake flags for the Windows build (missed in prior PR). Follow up to: - https://github.com/valhalla/valhalla/pull/2502/files /cc @kevinkreiser @mandeepsandhu
danpaz
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJS libvalhalla bindings, but then called the CHANGELOG validation script
using the wrong Node binary. For the moment, we drop this script entirely
which is currently a no-op (we're not using 'unreleased' as a section header).
Follow up to:
/cc @kevinkreiser @mandeepsandhu