Disable msse2 flags on Apple Silicon #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/CMakeLists.txt
Outdated
| @@ -108,7 +108,7 @@ function(valhalla_module) | |||
| # These options do not affect the ABI and should therefore be used whenever possible for | |||
| # predictable numerical results | |||
| # For the x86-64 compiler, these extensions are enabled by default. | |||
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "amd64|AMD64|x64|x86|x86_64") | |||
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "amd64|AMD64|x64|x86|x86_64") AND NOT CMAKE_OSX_ARCHITECTURES MATCHES "arm64") | |||
There was a problem hiding this comment.
strange, that seems redundant to me. i guess on ios builds it advertizes itself as x86 through CMAKE_SYSTEM_RPOCESSOR variable?
There was a problem hiding this comment.
CMAKE_SYSTEM_RPOCESSOR = x86_64 when we build it with arm64. I will figure out more soon, maybe some of dependencies override it
There was a problem hiding this comment.
@kevinkreiser , it fixes an issue with new Macs on arm64.
There was a problem hiding this comment.
CMAKE_OSX_ARCHITECTURES=arm64 setup -arch arm64 flag to compiler. I don't know, why CMAKE_SYSTEM_PROCESSOR=x86_64
There was a problem hiding this comment.
There was a problem hiding this comment.
oh i see its for the new mac arm architectures, thanks
deniskoronchik
force-pushed
the
m1-support
branch
2 times, most recently
from
26f748a to
5f76013
Compare
kevinkreiser
previously approved these changes
Sep 17, 2021
averkhaturau
previously approved these changes
Sep 28, 2021
deniskoronchik
dismissed stale reviews from averkhaturau and kevinkreiser
via
e4da98f
deniskoronchik
force-pushed
the
m1-support
branch
from
e4da98f to
87b5535
Compare
averkhaturau
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?