Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option for languge check skipping #119

Merged
merged 2 commits into from
May 7, 2018

Conversation

nschonni
Copy link
Member

Closes #118

This probably needs some sort of test, but I thought I'd see if this looks right as a start

README.md Outdated
@@ -175,7 +182,7 @@ and the [Travis CI doc page](https://docs.travis-ci.com/user/trusty-ci-environme

## License

Copyright Jörn Zaefferer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't removed, but there was trailing whitespace that Markdownlint was complainting about

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but it's wrong removing it because 2 trailing spaces mean a line break in Markdown ;)

@XhmikosR
Copy link
Member

A test would be perfect. But if not, we can still get this merged.

@XhmikosR XhmikosR merged commit 25455e8 into validator:master May 7, 2018
@nschonni nschonni deleted the no-langdetect branch May 10, 2018 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants