Updates for #848

CHANGELOG.md

@@ -1,7 +1,9 @@
 #### HEAD
 
-- Support for IP hostnames in `isEmail()`
+- Added support for IP hostnames in `isEmail()`
   ([#845](https://github.com/chriso/validator.js/pull/845))
+- Added a `no_symbols` option to `isNumeric()`
+  ([#848](https://github.com/chriso/validator.js/pull/848))
 - New and improved locales
   ([#856](https://github.com/chriso/validator.js/pull/856),
    [#870](https://github.com/chriso/validator.js/pull/870),

README.md

@@ -106,7 +106,7 @@ Validator                               | Description
 **isMobilePhone(str, locale [, options])**          | check if the string is a mobile phone number,<br/><br/>(locale is either an array of locales (e.g `['sk-SK', 'sr-RS']`) OR one of `['ar-AE', 'ar-DZ', 'ar-EG', 'ar-IQ', ar-JO', 'ar-KW', 'ar-SA', 'ar-SY', 'ar-TN', 'be-BY', 'bg-BG', 'bn-BD', 'cs-CZ', 'de-DE', 'da-DK', 'el-GR', 'en-AU', 'en-CA', 'en-GB', 'en-HK', 'en-IN',  'en-KE', 'en-NG', 'en-NZ', 'en-RW', 'en-SG', 'en-UG', 'en-US', 'en-TZ', 'en-ZA', 'en-ZM', 'en-PK', 'es-ES', 'et-EE', 'fa-IR', 'fi-FI', 'fr-FR', 'he-IL', 'hu-HU', 'it-IT', 'ja-JP', 'kk-KZ', 'ko-KR', 'lt-LT', 'ms-MY', 'nb-NO', 'nn-NO', 'pl-PL', 'pt-PT', 'pt-BR', 'ro-RO', 'ru-RU', 'sk-SK', 'sr-RS', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA', 'vi-VN', 'zh-CN', 'zh-HK', 'zh-TW']` OR 'any'. If 'any' is used, function will check if any of the locales match).<br/><br/>`options` is an optional object that can be supplied with the following keys: `strictMode`, if this is set to `true`, the mobile phone number must be supplied with the country code and therefore must start with `+`.
 **isMongoId(str)**                      | check if the string is a valid hex-encoded representation of a [MongoDB ObjectId][mongoid].
 **isMultibyte(str)**                    | check if the string contains one or more multibyte chars.
-**isNumeric(str [, options])**                      | check if the string contains only numbers.<br/><br/>`options` is an object which defaults to `{noSymbols: false}`, meaning that it will validate strings that do contain any of `+`, `-`, or `.`.
+**isNumeric(str [, options])**                      | check if the string contains only numbers.<br/><br/>`options` is an object which defaults to `{no_symbols: false}`. If `no_symbols` is true, the validator will reject numeric strings that feature a symbol (e.g. `+`, `-`, or `.`).
 **isPort(str)**                         | check if the string is a valid port number.
 **isPostalCode(str, locale)**           | check if the string is a postal code,<br/><br/>(locale is one of `[ 'AT', 'AU', 'BE', 'BG', 'CA', 'CH', 'CZ', 'DE', 'DK', 'DZ', 'EE', 'ES', 'FI', 'FR', 'GB', 'GR', 'HR', 'HU', 'IL', 'IN', 'IS', 'IT', 'JP', 'KE', 'LI', 'LT', 'LU', 'LV', 'MX', 'NL', 'NO', 'PL', 'PT', 'RO', 'RU', 'SA', 'SE', 'SI', 'TN', 'TW', 'US', 'ZA', 'ZM' ]` OR 'any'. If 'any' is used, function will check if any of the locals match. locale list is `validator.isPostalCodeLocales`.).
 **isSurrogatePair(str)**                | check if the string contains any surrogate pairs chars.

lib/isNumeric.js

@@ -16,7 +16,7 @@ var numericNoSymbols = /^[0-9]+$/;
 
 function isNumeric(str, options) {
   (0, _assertString2.default)(str);
-  if (options && options.noSymbols) {
+  if (options && options.no_symbols) {
     return numericNoSymbols.test(str);
   }
   return numeric.test(str);

src/lib/isNumeric.js

@@ -5,7 +5,7 @@ const numericNoSymbols = /^[0-9]+$/;
 
 export default function isNumeric(str, options) {
   assertString(str);
-  if (options && options.noSymbols) {
+  if (options && options.no_symbols) {
     return numericNoSymbols.test(str);
   }
   return numeric.test(str);

test/validators.js

@@ -1562,7 +1562,7 @@ describe('Validators', () => {
     test({
       validator: 'isNumeric',
       args: [{
-        noSymbols: true,
+        no_symbols: true,
       }],
       valid: [
         '123',

validator.js

@@ -617,7 +617,7 @@ var numericNoSymbols = /^[0-9]+$/;
 
 function isNumeric(str, options) {
   assertString(str);
-  if (options && options.noSymbols) {
+  if (options && options.no_symbols) {
     return numericNoSymbols.test(str);
   }
   return numeric.test(str);