Adds 7.2.4-rc1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
commented
Apr 9, 2024
| push: | ||
| workflow_dispatch: | ||
| workflow_run: | ||
| workflows: [GitHub CI] |
There was a problem hiding this comment.
This will only run once we push the images to dockerhub
| @@ -137,9 +137,6 @@ for version in "${versions[@]}"; do | |||
| | ( | |||
| startswith(env.rcVersion + ".") | |||
| or startswith(env.rcVersion + "-") | |||
| ) and ( | |||
| index("-") | |||
There was a problem hiding this comment.
This script did not allow -rc versions to get published
hpatro
approved these changes
Apr 9, 2024
| "alpine": { | ||
| "version": "3.19" | ||
| }, | ||
| "gosu": { |
There was a problem hiding this comment.
Its golang super user https://github.com/tianon/gosu
It is used to step down from root during container startup, specially for entrypoint.
| @@ -7,8 +7,10 @@ | |||
| Please open an Issue stating your question on [the Valkey Community](https://github.com/valkey-io/valkey-container/issues). | |||
|
|
|||
| # Supported tags and respective `Dockerfile` links | |||
| - [`unstable`](https://github.com/valkey-io/valkey-container/blob/master/unstable/debian/Dockerfile) | |||
| - [`unstable-alpine`](https://github.com/valkey-io/valkey-container/blob/master/unstable/alpine/Dockerfile) | |||
| - [`unstable`, `unstable-bookworm`](https://github.com/valkey-io/valkey-container/blob/master/unstable/debian/Dockerfile) | |||
There was a problem hiding this comment.
Any reason why debian doesn't need to be added as suffix ?
it is done by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 7.2.4-rc1 and updates docker hub descriptions with new tags