-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/topics/protocol.md
needs work: naming, links, and malformed HTML
#127
Comments
I'll drop, refactor, etc. as appropriate.
I'll refactor/minify. (It's of some historical interest.)
I'll delete all these manually added anchors and update all links to these sections, from this and other pages, to the correct ones. |
…ors, valkey-io#127 Refactor the sections about various kinds of nulls. Signed-off-by: Viktor Söderqvist <[email protected]>
@stockholmux This page is still not visible on the website. Does it still have issues? |
@zuiderkwast Indeed there is a problem. The content looks generally fine but there is something weird going on with the file, when I remove the file from the publishing hold it renders like this: The weird single bullet seems to be related to some sort of errant character somewhere in the frontmatter section. It also blows up my markdown linter in vscode (note the related errors shown while mousing over the errors don't seem to be describing anything useful: MD041, MD022): When I manually remove the frontmatter in the source file and re-write it there it renders fine: It's quite weird really; none of the other topics have this problem. I don't see a tab character anywhere but that would be my first guess; the fix should be easy - just remove the existing frontmatter and re-enter it cleanly. |
Thanks for the hint! Now I've spotted something: The frontmatter starts with 3 dashes and ends with 4 dashes. Can that be it? |
Gosh! I didn't notice the extra dash but that'll do it! |
Signed-off-by: Viktor Söderqvist <[email protected]>
In pre-publishing review (#91), I found several issues on
/topics/protocol.md
"Valkey serialization protocol specification" title
Drop "Valkey"
It wasn't designed specifically for Valkey. Refactor.
This isn't relevant for Valkey/2024.
Links to a hash that doesn't exist.
The
a
tag isn't closed causing the entire section to become an unclickable link.The
a
tag isn't closed causing the entire first line to become an unclickable linkThe text was updated successfully, but these errors were encountered: