Detail the issue of redirection occurring within a transaction. #168
Conversation
Signed-off-by: zhaozhao.zz <[email protected]>
There was a problem hiding this comment.
Looks good. The English can probably be improved a little.
We should also mention this in the cluster-spec, at least add a link from cluster-spec to here. The cluster spec is what cluster client authors would read and where MOVED is documented.
EXEC can also return -TRYAGAIN and -ASK, right? But that's maybe better to mention in the cluster spec than here.
|
feel free to modify the doc @zuiderkwast , I'm not a native English speaker, haha. |
Me neither. 😜 But I can try. |
| MULTI ==> +OK | ||
| SET x y ==> +QUEUED | ||
| slot {x} is migrated to other node | ||
| EXEC ==> -MOVED |
There was a problem hiding this comment.
I didn't see the EXECABORT behavior documented in this file or anywhere in the doc repo. Can we add it here too for completeness?
|
@soloestoy Will you reply to the comments? I want to merge this. |
|
BUMP @soloestoy, it is now three months later. Are you going to resolve some comments or just merge it as is? |
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: zhaozhao.zz <[email protected]>
Signed-off-by: zhaozhao.zz <[email protected]>
|
wow, I forgot it... it's ready to merge now |
doc for valkey-io/valkey#895