Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about server domain object for LUA #85

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

madolson
Copy link
Member

@madolson madolson commented May 4, 2024

Documents the behavior for the new server top level domain object and the new Lua fields. Also updates all of the examples to use the server object. Also includes some cleanup to references to "Valkey serialization protocol" which doesn't exist.

There will be some minimal conflicts with #22, as it attempts to remove the versioning references which this file also does for the files that were touched.

@madolson madolson requested a review from zuiderkwast May 4, 2024 20:15
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I just think we should keep version information. Let's discuss that.

topics/lua-api.md Show resolved Hide resolved
topics/lua-api.md Outdated Show resolved Hide resolved
topics/lua-api.md Outdated Show resolved Hide resolved
topics/lua-api.md Show resolved Hide resolved
topics/lua-api.md Outdated Show resolved Hide resolved
topics/lua-api.md Show resolved Hide resolved
topics/lua-api.md Outdated Show resolved Hide resolved
topics/lua-api.md Show resolved Hide resolved
topics/lua-api.md Outdated Show resolved Hide resolved
@zuiderkwast zuiderkwast merged commit e869a38 into main Jul 3, 2024
3 checks passed
@zuiderkwast zuiderkwast deleted the cleanup_lua branch July 3, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants