Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to reference glide-rs as a separate external package - Yarn fix #2943

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Refactor to reference glide-rs as a separate external package - Yarn fix #2943

wants to merge 6 commits into from

Conversation

Muhammad-awawdi-amazon
Copy link
Collaborator

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon commented Jan 12, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2680

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon added node Node.js wrapper CI/CD CI/CD related Users Pain An issue known to cause users pain, generaly open by the user. User issue Issue openned by users labels Jan 12, 2025
@Muhammad-awawdi-amazon Muhammad-awawdi-amazon requested a review from a team as a code owner January 12, 2025 13:01
@Muhammad-awawdi-amazon Muhammad-awawdi-amazon changed the base branch from yarn-fix to main January 12, 2025 13:02
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you please document your changes by updating PR description. What packages are published, what dependency do they have?
Consider adding an example app which uses yarn.

@yipin-chen yipin-chen added this to the 1.3 milestone Jan 20, 2025
@Muhammad-awawdi-amazon Muhammad-awawdi-amazon marked this pull request as draft January 22, 2025 09:57
@yipin-chen yipin-chen modified the milestones: 1.3, 1.4 Jan 27, 2025
@Muhammad-awawdi-amazon
additional refactoring
3ed65fe 
Signed-off-by: Muhammad Awawdi <[email protected]>
@Muhammad-awawdi-amazon
update
14ff198 
Signed-off-by: Muhammad Awawdi <[email protected]>
@Muhammad-awawdi-amazon
prettier
8925f19 
Signed-off-by: Muhammad Awawdi <[email protected]>
@Muhammad-awawdi-amazon
fix
23d5443 
Signed-off-by: Muhammad Awawdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@avifenesh avifenesh Awaiting requested review from avifenesh

At least 1 approving review is required to merge this pull request.

Assignees

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon

Labels
CI/CD CI/CD related node Node.js wrapper User issue Issue openned by users Users Pain An issue known to cause users pain, generaly open by the user.
Projects
Valkey-GLIDE - internal
Status: In Progress
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Muhammad-awawdi-amazon @Yury-Fridlyand @yipin-chen