Core: Add new CommandRequest - Pipeline #2954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Shoham Elias <[email protected]>
shohamazon
added
Rust core
ikolomi
reviewed
Jan 16, 2025
| pipeline: &'a redis::Pipeline, | ||
| ) -> redis::RedisFuture<'a, Value> { | ||
| let command_count = pipeline.cmd_iter().count(); | ||
| let _offset = command_count + 1; //TODO: check |
ikolomi
reviewed
Jan 16, 2025
| .push((index, inner_index)); | ||
| } | ||
|
|
||
| async fn routes_pipeline_commands( |
There was a problem hiding this comment.
find a better name and make it shorter
ikolomi
reviewed
Jan 16, 2025
| pipeline: &crate::Pipeline, | ||
| core: Core<C>, | ||
| ) -> RedisResult<( | ||
| HashMap<String, (Pipeline, C, Vec<(usize, Option<usize>)>)>, |
ikolomi
reviewed
Jan 16, 2025
| match cluster_routing::RoutingInfo::for_routable(cmd) { | ||
| Some(cluster_routing::RoutingInfo::SingleNode(SingleNodeRoutingInfo::Random)) | ||
| | None => { | ||
| if pipelines_by_connection.is_empty() { |
ikolomi
reviewed
Jan 16, 2025
| } else { | ||
| // since the map is not empty, add the command to a random connection within the map. | ||
| let mut rng = rand::thread_rng(); | ||
| let keys: Vec<_> = pipelines_by_connection.keys().cloned().collect(); |
There was a problem hiding this comment.
think about way not to clone the addresses
ikolomi
reviewed
Jan 16, 2025
| Self::get_connection(route, core, None), | ||
| ) | ||
| .await | ||
| if pipeline.is_atomic() { |
There was a problem hiding this comment.
refactor, make it readable (shorter)
ikolomi
reviewed
Jan 16, 2025
| ) | ||
| .await | ||
| } else { | ||
| let (pipelines_by_connection, response_policies) = |
ikolomi
reviewed
Jan 16, 2025
| Self::routes_pipeline_commands(&pipeline, core.clone()) | ||
| .await | ||
| .map_err(|err| (OperationTarget::FanOut, err))?; | ||
| let mut values_and_addresses = vec![Vec::new(); pipeline.len()]; |
There was a problem hiding this comment.
command return values per pipeline?
ikolomi
reviewed
Jan 16, 2025
| for (index, routing_info, response_policy) in response_policies { | ||
| #[allow(clippy::type_complexity)] | ||
| // Safely access `values_and_addresses` for the current index | ||
| let response_receivers: Vec<( |
There was a problem hiding this comment.
use structs for complex types
ikolomi
reviewed
Jan 16, 2025
|
|
||
| // Collect final responses | ||
| for mut value in values_and_addresses.into_iter() { | ||
| assert_eq!(value.len(), 1); |
There was a problem hiding this comment.
dont use asserts in prod code
There was a problem hiding this comment.
Use index 0 instead of poping and unwrapping
ikolomi
reviewed
Jan 16, 2025
| .map_err(|err| (OperationTarget::FanOut, err))?; | ||
|
|
||
| // Update `values_and_addresses` for the current index | ||
| values_and_addresses[index] = vec![(aggregated_response, "".to_string())]; |
There was a problem hiding this comment.
use index 0 for storing aggregated_response
ikolomi
reviewed
Jan 16, 2025
glide-core/src/socket_listener.rs
Outdated
There was a problem hiding this comment.
Lets try to use pipeline for both transaction and pipeline, differentiating by is_atomic
ikolomi
reviewed
Jan 16, 2025
| @@ -501,6 +501,10 @@ message Transaction { | |||
| repeated Command commands = 1; | |||
| } | |||
|
|
|||
| message Pipeline { | |||
There was a problem hiding this comment.
lets remove Transaction and use Pipeline + is_atomic flag
Signed-off-by: Shoham Elias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: