Add source distribution upload to the PyPi-cd workflow #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with a rc - https://pypi.org/project/valkey-glide/1.3.0rc5/#files
|
| @@ -198,31 +198,64 @@ jobs: | |||
| path: python/wheels | |||
| if-no-files-found: error | |||
|
|
|||
| publish-to-pypi: | |||
| build-source-dist-and-publish-to-pypi: | |||
There was a problem hiding this comment.
I propose to create another job to build sources and add it there as a dependency (needs section)
There was a problem hiding this comment.
It will require to upload the build files and then download them, I think it's unnecessary and makes sense to keep it in the same job due to this reason
liorsve
force-pushed
the
lior/publish-dist-pypi
branch
from
ee8694f to
071097c
Compare
liorsve
force-pushed
the
lior/publish-dist-pypi
branch
from
071097c to
ccdc283
Compare
barshaul
reviewed
Feb 23, 2025
barshaul
approved these changes
Feb 23, 2025
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
Signed-off-by: lior sventitzky <[email protected]>
liorsve
force-pushed
the
lior/publish-dist-pypi
branch
from
ccdc283 to
3f7cf8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (): [#3189 ]
Checklist
Before submitting the PR make sure the following are checked: