Add CI tests for benchmarks. #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shachlanAmazon
force-pushed
the
ci-benchmark
branch
2 times, most recently
from
5113dd9 to
89cd507
Compare
shachlanAmazon
force-pushed
the
ci-benchmark
branch
from
a444cde to
94bc282
Compare
This was implemented for some actions. Matching the behavior for all.
shachlanAmazon
force-pushed
the
ci-benchmark
branch
5 times, most recently
from
901e529 to
8173fd3
Compare
shachlanAmazon
force-pushed
the
ci-benchmark
branch
from
8173fd3 to
370c43f
Compare
barshaul
reviewed
Dec 10, 2023
| fillDB $currentDataSize | ||
| if [ -z "$minimal" ]; | ||
| then | ||
| flushDB |
There was a problem hiding this comment.
it's a hack - we rely implicitly on building (npx tsc) the Js utilities folder before running the node benchmark, because they share types.
barshaul
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Allow benchmarks to run in a minimal fashion, that shouldn't take a long while.
Add CI task for each language, so that benchmarks will run for it.
Add relevant file extensions for changes that should trigger CI for each language.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.