[feat] add Ubuntu 24.04 Noble package support #971
Conversation
Signed-off-by: Alan Scherger <[email protected]>
flyinprogrammer
force-pushed
the
unstable
branch
from
6dfe662 to
ebd109e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #971 +/- ##
============================================
- Coverage 70.50% 70.44% -0.06%
============================================
Files 114 114
Lines 61742 61742
============================================
- Hits 43532 43495 -37
- Misses 18210 18247 +37
|
We had some instability around when we launched Valkey 8 because of the features. You can find most of the documented issues here: https://github.com/valkey-io/valkey/issues?q=is%3Aopen+is%3Aissue+label%3Atest-failure. The CI pretty stable generally. |
| @@ -12,6 +12,12 @@ | |||
| "type": "deb", | |||
| "platform": "focal" | |||
| }, | |||
| { | |||
| "arch": "x86_64", | |||
| "target": "ubuntu24.04", | |||
There was a problem hiding this comment.
@roshkhatri I see we are skipping 22.04. I'm Okay adding these, but maybe we should document our strategy here somewhere?
There was a problem hiding this comment.
Like focus on Ubuntu LTS releases would make sense to me.
There was a problem hiding this comment.
@roshkhatri @bbarani Can we make an issue to document our strategy and follow through on updating the website. I think I'll merge this now and we can follow up on the next release adding these images.
There was a problem hiding this comment.
Yes I have opened an issue for the website repo here valkey-io/valkey-io.github.io#164.
There was a problem hiding this comment.
Also I think there is a problem, for compiling, we use https://github.com/marketplace/actions/run-on-architecture for the binaries for ARM architecture. Github ARM runners are in GA but as github-hosted runners, there are not in opensource according to https://github.com/orgs/community/discussions/19197#discussioncomment-10550689.
I will look into more options.
In theory this might capture this request for an issue! 🌮