Tabset component removeTab method doesn't work with Angular Universal

[agustinhaller]

• Angular version: 4.4.3
• ngx-bootstrap version: 1.9.3
• build system: angular cli (Universal + AoT)
• Use case: Tabset component doesn't work with Angular Universal

There's a bug in the tabset component that's causing an error with angular universal.

The error I'm getting is:

TypeError: tab.elementRef.nativeElement.parentNode.removeChild is not a function    
at TabsetComponent.removeTab ...

I think the issue is caused because you are accessing the DOM directly in this line:

ngx-bootstrap/src/tabs/tabset.component.ts

Line 83 in b9ee706

tab.elementRef.nativeElement.parentNode.removeChild(

Maybe there's an easy fix for this using the Renderer2 removeChild method instead of parentNode.removeChild

I think this is a very important issue because a small issue is preventing ngx-bootstrap to work correctly with Angular Universal. After searching in this repo, I found that this same issue may be affecting the modal directive as you use the parentNode.removeChild directly through the DOM instead of using the Renderer2 method.

[agustinhaller]

@valorkin Do you think using Renderer2 would be a good solution for this issue?

[valorkin]

yep, it should be

[stemyke]

@valorkin I just ran into the same issue 😄