Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add ability to pass data to modal component #2293

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

IlyaSurmay
Copy link
Contributor

@IlyaSurmay IlyaSurmay commented Jul 27, 2017

closes #2290
closes #2275
closes #2251
fixes #2294

@valorkin valorkin added this to the v1.8.1 milestone Jul 27, 2017
@codecov
Copy link

codecov bot commented Jul 27, 2017

Codecov Report

Merging #2293 into development will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2293      +/-   ##
===============================================
- Coverage        87.52%   87.49%   -0.04%     
===============================================
  Files               95       95              
  Lines             2693     2694       +1     
  Branches           362      362              
===============================================
  Hits              2357     2357              
- Misses             212      213       +1     
  Partials           124      124
Impacted Files Coverage Δ
src/component-loader/component-loader.class.ts 76.61% <0%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d67ef8...0ba1e23. Read the comment docs.

@valorkin valorkin merged commit 8ac13f9 into development Jul 28, 2017
@valorkin valorkin deleted the feat-modal-data branch July 28, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants