Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add swedish locale #2804

Merged
merged 5 commits into from
Oct 20, 2017

Conversation

PerfectlyNormal
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #2804 into development will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2804      +/-   ##
===============================================
+ Coverage        70.38%   70.44%   +0.06%     
===============================================
  Files              137      137              
  Lines             4092     4094       +2     
  Branches           711      712       +1     
===============================================
+ Hits              2880     2884       +4     
+ Misses             913      912       -1     
+ Partials           299      298       -1
Impacted Files Coverage Δ
src/tabs/tab.directive.ts 88.37% <0%> (+1.19%) ⬆️
src/tooltip/tooltip.directive.ts 57.89% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b53225...8f56017. Read the comment docs.

@valorkin
Copy link
Member

@PerfectlyNormal hey, thanks for PR!
it would be awesome if you will migrate tests for locale too, could a separate PR

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit eccb382 into valor-software:development Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants