feat(datepicker): datepicker now is a directive not a component #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serving datepicker as a component will get back as an inline more only BREAKING CHANGE: - datepicker and daterange component selectors was removed - now datepicker available only as directive
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## development #3125 +/- ##
============================================
Coverage 65.31% 65.31%
============================================
Files 209 209
Lines 5628 5628
Branches 990 990
============================================
Hits 3676 3676
Misses 1689 1689
Partials 263 263
Continue to review full report at Codecov.
|
|
Tested, looks good. |
|
@YevheniiaMazur thanks :) |
|
Did this remove the ability to create an inline datepicker? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serving datepicker as a component will get back as an inline more only
BREAKING CHANGE:
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.