Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): Updated timepicker component to bootstrap 4 #4197

Merged
merged 2 commits into from
Apr 24, 2018
Merged

feat(timepicker): Updated timepicker component to bootstrap 4 #4197

merged 2 commits into from
Apr 24, 2018

Conversation

nagos
Copy link
Contributor

@nagos nagos commented Apr 5, 2018

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Bootstrap 4 removed .hidden class.
bootstrap migration guide

The .hidden and .show classes have been removed because they conflicted with jQuery’s $(...).hide() and $(...).show() methods. Instead, try toggling the [hidden] attribute or use inline styles like style="display: none;" and style="display: block;".

@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@37300b1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #4197   +/-   ##
==============================================
  Coverage               ?   72.29%           
==============================================
  Files                  ?      254           
  Lines                  ?     8266           
  Branches               ?     1579           
==============================================
  Hits                   ?     5976           
  Misses                 ?     1868           
  Partials               ?      422

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37300b1...339f0b3. Read the comment docs.

@valorkin valorkin changed the title Updated timepicker component to bootstrap 4 feat(timepicker): Updated timepicker component to bootstrap 4 Apr 24, 2018
@ghost ghost assigned valorkin Apr 24, 2018
@EvilAlexei EvilAlexei self-requested a review April 24, 2018 13:03
@valorkin
Copy link
Member

thanks for your PR!
sorry for the delay, was busy organizing https://ngtalks.io/

@valorkin valorkin merged commit 190e2db into valor-software:development Apr 24, 2018
@ghost ghost removed the ready for tests label Apr 24, 2018
@nagos nagos deleted the my-fix-branch branch April 24, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants