-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename modal-named arguments/variables related to SendConfirmation #6454
Conversation
…t-item-to-new-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6454 +/- ##
==========================================
- Coverage 89.11% 89.10% -0.01%
==========================================
Files 731 731
Lines 31859 31859
Branches 5764 5764
==========================================
- Hits 28390 28389 -1
- Misses 3423 3424 +1
Partials 46 46
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -77,7 +77,7 @@ export enum Screens { | |||
SelectProvider = 'SelectProvider', | |||
SendSelectRecipient = 'SendSelectRecipient', | |||
SendConfirmation = 'SendConfirmation', | |||
SendConfirmationModal = 'SendConfirmationModal', | |||
SendConfirmationFromExternal = 'SendConfirmationFromExternal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that this is only used for Bidali and the redirect is gonna come from the "external" source (dapp in this case) - I figured this name might fit well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR is related to some renames caused by removal of a modal version of
SendConfirmation
screeen. The following changes are applied:Screens.SendConfirmationModal
toScreens.SendConfirmationFromExternal
fromModal
tofromExternal
arguments/variables in files related to the Send flowTest plan
No extra tests needed, all the existing tests work as intended
Related issues
Relates to RET-1295
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: