Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename modal-named arguments/variables related to SendConfirmation #6454

Merged
merged 33 commits into from
Jan 27, 2025

Conversation

sviderock
Copy link
Contributor

Description

This PR is related to some renames caused by removal of a modal version of SendConfirmation screeen. The following changes are applied:

  • rename Screens.SendConfirmationModal to Screens.SendConfirmationFromExternal
  • rename fromModal to fromExternal arguments/variables in files related to the Send flow

Test plan

No extra tests needed, all the existing tests work as intended

Related issues

Relates to RET-1295

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@sviderock sviderock changed the title chore: rename fromModal to fromExternal chore: rename modal-named arguments/variables related to SendConfirmation Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (dcac9cf) to head (b7a7e6a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6454      +/-   ##
==========================================
- Coverage   89.11%   89.10%   -0.01%     
==========================================
  Files         731      731              
  Lines       31859    31859              
  Branches     5764     5764              
==========================================
- Hits        28390    28389       -1     
- Misses       3423     3424       +1     
  Partials       46       46              
Files with missing lines Coverage Δ
src/fiatExchanges/saga.ts 85.86% <100.00%> (ø)
src/navigator/Screens.tsx 100.00% <100.00%> (ø)
src/send/SendConfirmation.tsx 94.44% <100.00%> (ø)
src/send/actions.ts 100.00% <ø> (ø)
src/send/saga.ts 77.01% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcac9cf...b7a7e6a. Read the comment docs.

@@ -77,7 +77,7 @@ export enum Screens {
SelectProvider = 'SelectProvider',
SendSelectRecipient = 'SendSelectRecipient',
SendConfirmation = 'SendConfirmation',
SendConfirmationModal = 'SendConfirmationModal',
SendConfirmationFromExternal = 'SendConfirmationFromExternal',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that this is only used for Bidali and the redirect is gonna come from the "external" source (dapp in this case) - I figured this name might fit well.

Base automatically changed from slava/add-new-review-to-send-flow to main January 27, 2025 14:47
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sviderock sviderock added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 9bed0b9 Jan 27, 2025
15 checks passed
@sviderock sviderock deleted the slava/rename-send-confirmation-modal branch January 27, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants