Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): migrate some remote config to Statsig and remove legacy configs #6473

Merged
merged 14 commits into from
Feb 5, 2025

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Feb 3, 2025

Description

This PR removes some unused remote config configs, and replaces the following with statsig:

  • wallet connect v2 enabled -> feature gate (note that feature gates always default to false, but we should default this value to true since then builders can access wallet connect without a statsig account, context)
  • celo education url -> new item in app_config links

Note that the expanded pincode blocklist remote config flag doesn't actually exist in the remote config console - so it is always defaulting to false, so i've just removed the functionality.

Removed unused config:

  • logPhoneNumberTypeEnabled
  • pincodeUseExpandedBlocklist
  • coinbasePayEnabled
  • maxSwapSlippagePercentage
  • networkTimeoutSeconds

Test plan

n/a

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.02%. Comparing base (d2e6558) to head (1bf5795).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ons/feed/detailContent/TransferReceivedContent.tsx 83.33% 1 Missing ⚠️
src/walletConnect/saga.ts 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6473      +/-   ##
==========================================
- Coverage   89.06%   89.02%   -0.05%     
==========================================
  Files         731      729       -2     
  Lines       31935    31871      -64     
  Branches     6149     6141       -8     
==========================================
- Hits        28444    28373      -71     
- Misses       3294     3300       +6     
- Partials      197      198       +1     
Files with missing lines Coverage Δ
src/app/reducers.ts 26.82% <ø> (ø)
src/app/saga.ts 70.61% <ø> (ø)
src/app/selectors.ts 96.55% <ø> (-0.51%) ⬇️
src/firebase/firebase.ts 41.02% <ø> (+0.20%) ⬆️
src/firebase/remoteConfigValuesDefaults.ts 100.00% <ø> (ø)
src/navigator/SettingsMenu.tsx 95.00% <100.00%> (+0.05%) ⬆️
src/pincode/PincodeSet.tsx 94.39% <100.00%> (-0.21%) ⬇️
src/pincode/authentication.ts 87.24% <ø> (-0.78%) ⬇️
src/redux/migrations.ts 97.02% <100.00%> (+<0.01%) ⬆️
src/redux/store.ts 89.23% <ø> (ø)
... and 5 more

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e6558...1bf5795. Read the comment docs.

@kathaypacific kathaypacific changed the title chore: replace walletConnect remote config with Statsig, remove unused chore: replace some remote config with Statsig, remove unused remote configs Feb 3, 2025
@kathaypacific kathaypacific changed the title chore: replace some remote config with Statsig, remove unused remote configs chore(config): migrate some remote config to Statsig and remove legacy configs Feb 3, 2025
@kathaypacific kathaypacific marked this pull request as ready for review February 3, 2025 10:41
Copy link

emerge-tools bot commented Feb 3, 2025

1 build decreased size

Name Version Download Change Install Change Approval
Celo (test)
org.celo.mobile.test
1.103.0 (168) 25.4 MB ⬇️ 97.6 kB (-0.38%) 63.6 MB ⬇️ 142.0 kB (-0.22%) N/A

Celo (test) 1.103.0 (168)
org.celo.mobile.test

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 142.0 kB (-0.22%)
Total download size change: ⬇️ 97.6 kB (-0.38%)

Largest size changes

Item Install Size Change
main.jsbundle ⬇️ -143.4 kB
RNSVGTSpan.getLinePath:context: ⬇️ -6.4 kB
Sentry.SentryReplayOptions.init(dictionary) ⬆️ 2.6 kB
RCTCxxMethod.invokeWithBridge:module:arguments: ⬇️ -2.5 kB
SentryOptions.validateOptions:didFailWithError: ⬇️ -2.5 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@kathaypacific
Copy link
Collaborator Author

(The CI is not passing because the required statsig config has not been reviewed and committed yet)

Copy link
Contributor

@sviderock sviderock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kathaypacific kathaypacific added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 60519ee Feb 5, 2025
16 checks passed
@kathaypacific kathaypacific deleted the kathy/remote-config-statsig branch February 5, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants