-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(config): migrate some remote config to Statsig and remove legacy configs #6473
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6473 +/- ##
==========================================
- Coverage 89.06% 89.02% -0.05%
==========================================
Files 731 729 -2
Lines 31935 31871 -64
Branches 6149 6141 -8
==========================================
- Hits 28444 28373 -71
- Misses 3294 3300 +6
- Partials 197 198 +1
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
1 build decreased size
Celo (test) 1.103.0 (168)
|
Item | Install Size Change |
---|---|
main.jsbundle | ⬇️ -143.4 kB |
RNSVGTSpan.getLinePath:context: | ⬇️ -6.4 kB |
Sentry.SentryReplayOptions.init(dictionary) | ⬆️ 2.6 kB |
RCTCxxMethod.invokeWithBridge:module:arguments: | ⬇️ -2.5 kB |
SentryOptions.validateOptions:didFailWithError: | ⬇️ -2.5 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
(The CI is not passing because the required statsig config has not been reviewed and committed yet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR removes some unused remote config configs, and replaces the following with statsig:
Note that the expanded pincode blocklist remote config flag doesn't actually exist in the remote config console - so it is always defaulting to false, so i've just removed the functionality.
Removed unused config:
Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: