Get "Workspace to pull" on test_rdr to work again #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et one debug without being in testing mode
|
@kcmcg this PR will fix the problem where we could not test the new JSON credentials in STABLE today |
paulj3
commented
Sep 27, 2024
Comment on lines
-655
to
+663
| if($testingOnly[$urlKey] == "1") { | ||
| if(!$debugApi) { | ||
| echo "<pre>".htmlspecialchars($recordId." => ".var_export($rowData,true))."</pre>";echo "<br />"; | ||
| } | ||
| if($debugApi) { | ||
| echo "<pre>".htmlspecialchars($recordId." => ".var_export($rowData,true))."</pre>";echo "<br />"; | ||
| } | ||
| else { | ||
| if ($testingOnly[$urlKey] != "1") { |
There was a problem hiding this comment.
@kcmcg I am changing this around so we can use test_rdr without having to put the module in test mode, because we shouldn't have to stop the functionality to see a a debug on the test page.
kcmcg
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Kyle and I were rotating the JSON Auth tokens, we tried to test the RDR api on stable and ran into a problem where we were not able to pull a single record from RDR
After looking into this, it looks like this commit from 9 months ago removed the single project functionality.
I went through the
rdr_pullmethod and added this functionality back in without impacting it's cron results.