Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ajax call native JS. No jQuery dependency. #33

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

jorisvm
Copy link
Contributor

@jorisvm jorisvm commented Apr 4, 2024

I like the plugin. Great work, but I don't think we need jQuery for one simple ajax request. Keeping it lighweight for websites that can run without a jQuery dependency.

@vanpariyar
Copy link
Owner

Thanks @jorisvm for your contribution.

Can you please share your WordPress profile user name i can mention on the Repo

@vanpariyar vanpariyar added this to the 1.17 milestone Apr 5, 2024
@jorisvm
Copy link
Contributor Author

jorisvm commented Apr 5, 2024

@jorisvanmontfort is my WordPress user profile.

Copy link
Owner

@vanpariyar vanpariyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use wp_post_views_ajax_object.post_id

assets/js/ajax.js Show resolved Hide resolved
assets/js/ajax.js Outdated Show resolved Hide resolved
@vanpariyar vanpariyar merged commit 8f89b09 into vanpariyar:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants