Fix Time Format #119
Merged
Fix Time Format #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eric-kingu is attempting to deploy a commit to the vantageX's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
good stuff @eric-kingu . dont worry about the tests. i am still writing them here #117 . and you can see a lot of commits as this is my first time writing tests for the react typescript. |
vantage-ola
approved these changes
Aug 13, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vantage-ola
requested changes
Aug 13, 2024
There was a problem hiding this comment.
quick change @eric-kingu , change the placeholder value in UserAddLaptimes.tsx
variant='flushed' placeholder='6.59.34' and
<FormErrorMessage fontSize={'11px'}>Please enter a valid laptime (minutes.seconds.milliseconds)</FormErrorMessage>
to an appropriate value. thanks
vantage-ola
approved these changes
Aug 13, 2024
vantage-ola
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed time format on UserAddLaptime, in test-utils I commented a test to see if the format returns true, tried doing TDD but I didn't want to worsen your tests