Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/issue #8 and revert back to previous Laptime model #13

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix/issue #8 and revert back to previous Laptime model #13

merged 3 commits into from
Dec 22, 2023

Conversation

vantage-ola
Copy link
Owner

fix slight error,

@vantage-ola vantage-ola added the bug Something isn't working label Dec 22, 2023
@vantage-ola vantage-ola self-assigned this Dec 22, 2023
@vantage-ola vantage-ola linked an issue Dec 22, 2023 that may be closed by this pull request
api/collection/<collection_id>/collections routes GET all entries` returns empty erray even if the entry does not exist #8
Closed
Dozie2001
Dozie2001 reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Dozie2001 Dozie2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit repetitive, instead just change it to self.id that should work. It will just parse it to the ids of the respective class. Noticed the error and already working on a pull request to fix this and refactor the code

Dozie2001 added a commit to Dozie2001/track-now that referenced this pull request Dec 22, 2023
@Dozie2001
fixes vantage-ola#13
5ef1a8a
@Dozie2001 Dozie2001 mentioned this pull request Dec 22, 2023
Closed
@vantage-ola vantage-ola changed the title fix-only-models-to-dict fix/issue #8 and revert back to previous Laptime model Dec 22, 2023
@vantage-ola
Copy link
Owner Author

I had to revert to old previous Laptime model, after doing some testing fro other routes(i realized its returning wrong data and its messing up input GET and POST requests). acde457 We will work on refactoring repetitive and redundant code later, after the routes has been finished

@vantage-ola vantage-ola merged commit ca8310a into main Dec 22, 2023
@vantage-ola vantage-ola deleted the fix/issue#8 branch December 26, 2023 15:20
vantage-ola pushed a commit that referenced this pull request Dec 28, 2023
@Dozie2001
refactor corrections (#17)
720555f 
* fixes #13

* Fixes #7

* Simple refactoring for then db

* Still trying to fix this

* Fixes a little of #7

* Works with endpoints to much of my knowledge
vantage-ola pushed a commit that referenced this pull request Dec 29, 2023
@Dozie2001 @vantage-ola
refactor corrections (#17)
7a39be2 
* fixes #13

* Fixes #7

* Simple refactoring for then db

* Still trying to fix this

* Fixes a little of #7

* Works with endpoints to much of my knowledge
vantage-ola added a commit that referenced this pull request Dec 29, 2023
@vantage-ola @Dozie2001
Feature/unit test (#18)
39f0e16 
* update-DEPENDENCIES

* refactor corrections (#17)

* fixes #13

* Fixes #7

* Simple refactoring for then db

* Still trying to fix this

* Fixes a little of #7

* Works with endpoints to much of my knowledge

* add-missing-*track/track_id/* routes + remove print()

* +config+tests

* github-actions/ci/cd

* uncomment-error_handle

---------

Co-authored-by: Chidozie DAVID <[email protected]>
vantage-ola added a commit that referenced this pull request Jan 4, 2024
@vantage-ola @Dozie2001
V.1.0/backend (#21)
abb1629 
* Feature/unit test (#18)

* update-DEPENDENCIES

* refactor corrections (#17)

* fixes #13

* Fixes #7

* Simple refactoring for then db

* Still trying to fix this

* Fixes a little of #7

* Works with endpoints to much of my knowledge

* add-missing-*track/track_id/* routes + remove print()

* +config+tests

* github-actions/ci/cd

* uncomment-error_handle

---------

Co-authored-by: Chidozie DAVID <[email protected]>

* update-env-workflow.yml

* -backend/.DS_Store

* +mongo_db-pytest (#20)

* finishing-touches-backend

* finishing-touches-backend

---------

Co-authored-by: Chidozie DAVID <[email protected]>
vantage-ola added a commit that referenced this pull request Jan 4, 2024
@vantage-ola @Dozie2001
v.1.0/backend (#22)
d8ab62e 
* Feature/unit test (#18)

* update-DEPENDENCIES

* refactor corrections (#17)

* fixes #13

* Fixes #7

* Simple refactoring for then db

* Still trying to fix this

* Fixes a little of #7

* Works with endpoints to much of my knowledge

* add-missing-*track/track_id/* routes + remove print()

* +config+tests

* github-actions/ci/cd

* uncomment-error_handle

---------

Co-authored-by: Chidozie DAVID <[email protected]>

* update-env-workflow.yml

* -backend/.DS_Store

* +mongo_db-pytest (#20)

* finishing-touches-backend

* finishing-touches-backend

* mv-backend-dependencies

* fix-workflow

---------

Co-authored-by: Chidozie DAVID <[email protected]>
vantage-ola added a commit that referenced this pull request Jan 4, 2024
@vantage-ola @Dozie2001
merge (#23)
1a58db8 
* Feature/unit test (#18)

* update-DEPENDENCIES

* refactor corrections (#17)

* fixes #13

* Fixes #7

* Simple refactoring for then db

* Still trying to fix this

* Fixes a little of #7

* Works with endpoints to much of my knowledge

* add-missing-*track/track_id/* routes + remove print()

* +config+tests

* github-actions/ci/cd

* uncomment-error_handle

---------

Co-authored-by: Chidozie DAVID <[email protected]>

* update-env-workflow.yml

* -backend/.DS_Store

* +mongo_db-pytest (#20)

* finishing-touches-backend

* finishing-touches-backend

* mv-backend-dependencies

* fix-workflow

---------

Co-authored-by: Chidozie DAVID <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dozie2001 Dozie2001 Dozie2001 left review comments

Assignees

@vantage-ola vantage-ola

Labels
bug Something isn't working
Projects
TRACK NOW 🏁
Status: Done
Milestone
No milestone
2 participants
@vantage-ola @Dozie2001