Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy load youtube videos #84

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: lazy load youtube videos #84

merged 2 commits into from
Jul 15, 2024

Conversation

vantage-ola
Copy link
Owner

this fix, will use srcDoc to load the youtube picture first, then if the user clicks the picture, it loads the youtube video and autoplays. it is a decent solution to the issue i guess. any changes to the state will reload the component. which still doesnt fix the read more problem in #81

@vantage-ola vantage-ola linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for alpha-tracknow ready!

Name Link
🔨 Latest commit 16136af
🔍 Latest deploy log https://app.netlify.com/sites/alpha-tracknow/deploys/6694f837182d77000887c284
😎 Deploy Preview https://deploy-preview-84--alpha-tracknow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91
Accessibility: 97
Best Practices: 100
SEO: 83
PWA: 60
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vantage-ola vantage-ola merged commit 3ff7120 into main Jul 15, 2024
5 checks passed
@vantage-ola vantage-ola deleted the fix/lazyload branch July 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buggy lazyload youtube component
1 participant