Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or upgrade opencv-python #4

Closed
willgraf opened this issue Oct 19, 2021 · 0 comments · Fixed by #9
Closed

Remove or upgrade opencv-python #4

willgraf opened this issue Oct 19, 2021 · 0 comments · Fixed by #9
Labels
dependencies Updates to dependencies

Comments

@willgraf
Copy link
Contributor

requirements.txt declares opencv-python<4 as a dependency for this project, but it looks like cv2 is not used anywhere.

This dependency is vulnerable and should be upgraded to >=4.2.0.32 or removed from requirements.txt.
@willgraf willgraf added the dependencies Updates to dependencies label Oct 19, 2021
willgraf added a commit that referenced this issue Oct 19, 2021
@willgraf
Remove opencv-python from requirements.txt
59e9555 
Fixes #4
@willgraf willgraf mentioned this issue Oct 19, 2021
Closed
willgraf added a commit that referenced this issue Dec 8, 2021
@willgraf
Replace opencv-python with opencv-python-headless.
8e18459 
Update version to drop Python2 support.

Fixes #4.
@willgraf willgraf mentioned this issue Dec 8, 2021
Merged
willgraf added a commit that referenced this issue Dec 8, 2021
@willgraf
Update Dockerfile, fix imports, and lint docstrings. (#9)
52338fb 
* Drop .idea from project and add to .gitignore.

* Remove redundant build steps, rely on base image instead.

* Replace opencv-python with opencv-python-headless.

Update version to drop Python2 support.

Fixes #4.

* Upgrade pandas to v1.

* Update docstring formatting.

* Another docstring update.

* Sort imports with isort and remove unused imports.

* Ignore training.py from coverage report.

No need to report on this, it is untested

* Markdown linting.

* More docstring updates.

* Final docstring updates.

* PEP8

* opencv-headless does not need so many deps.

* Import DBSCAN from sklearn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Updates to dependencies
Projects
None yet
Milestone
No milestone
1 participant
@willgraf