perf(ui/switch): add class #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## dev #372 +/- ##
==========================================
+ Coverage 96.39% 96.41% +0.02%
==========================================
Files 209 209
Lines 4907 4936 +29
Branches 1047 991 -56
==========================================
+ Hits 4730 4759 +29
Misses 177 177
Continue to review full report at Codecov.
|
BeADre
reviewed
Apr 4, 2022
| <div | ||
| class="var-switch-block" | ||
| :class="[disabled || formDisabled ? 'var-switch__disable' : null]" | ||
| :class="classes('var-switch-block', [disabled || formDisabled, n('disable')])" |
There was a problem hiding this comment.
这里我命名有点问题 var-switch-block改成var-switch__block，var-switch__disable改成var-switch--disable ，less 文件里面也需要改哈
There was a problem hiding this comment.
Does the test file need to be modified?
There was a problem hiding this comment.
测试用例中的快照是var-switch-disable ，如果只是.vue和.less修改，yarn test 会失败
BeADre
approved these changes
Apr 4, 2022
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change information