Reverts "Add FlutterMacOS.xcframework artifact (flutter#143244)" (flu…

…tter#144253) Reverts flutter#143244 Initiated by: vashworth Reason for reverting: Increased `flutter_framework_uncompressed_bytes` - see flutter#144251 Original PR Author: vashworth Reviewed By: {jmagman} This change reverts the following previous change: Original Description: Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`. Part of flutter#126016.
vashworth · Feb 27, 2024 · 7f2b238 · 7f2b238
1 parent 616a026
commit 7f2b238
Show file tree

Hide file tree

Showing 11 changed files with 83 additions and 322 deletions.
diff --git a/dev/bots/test.dart b/dev/bots/test.dart
@@ -1728,9 +1728,9 @@ List<String> binariesWithEntitlements(String flutterRoot) {
 /// cache.
 List<String> binariesWithoutEntitlements(String flutterRoot) {
   return <String>[
-    'artifacts/engine/darwin-x64-profile/FlutterMacOS.xcframework/macos-arm64_x86_64/FlutterMacOS.framework/Versions/A/FlutterMacOS',
-    'artifacts/engine/darwin-x64-release/FlutterMacOS.xcframework/macos-arm64_x86_64/FlutterMacOS.framework/Versions/A/FlutterMacOS',
-    'artifacts/engine/darwin-x64/FlutterMacOS.xcframework/macos-arm64_x86_64/FlutterMacOS.framework/Versions/A/FlutterMacOS',
+    'artifacts/engine/darwin-x64-profile/FlutterMacOS.framework/Versions/A/FlutterMacOS',
+    'artifacts/engine/darwin-x64-release/FlutterMacOS.framework/Versions/A/FlutterMacOS',
+    'artifacts/engine/darwin-x64/FlutterMacOS.framework/Versions/A/FlutterMacOS',
     'artifacts/engine/darwin-x64/font-subset',
     'artifacts/engine/darwin-x64/impellerc',
     'artifacts/engine/darwin-x64/libpath_ops.dylib',
@@ -1764,9 +1764,6 @@ List<String> signedXcframeworks(String flutterRoot) {
     'artifacts/engine/ios-release/extension_safe/Flutter.xcframework',
     'artifacts/engine/ios/Flutter.xcframework',
     'artifacts/engine/ios/extension_safe/Flutter.xcframework',
-    'artifacts/engine/darwin-x64-profile/FlutterMacOS.xcframework',
-    'artifacts/engine/darwin-x64-release/FlutterMacOS.xcframework',
-    'artifacts/engine/darwin-x64/FlutterMacOS.xcframework',
   ]
   .map((String relativePath) => path.join(flutterRoot, 'bin', 'cache', relativePath)).toList();
 }

diff --git a/dev/devicelab/lib/tasks/plugin_tests.dart b/dev/devicelab/lib/tasks/plugin_tests.dart
@@ -118,12 +118,6 @@ class PluginTest {
     // Currently this test is only implemented for macOS; it can be extended to
     // others as needed.
     if (buildTarget == 'macos') {
-      // When using a local engine, podhelper.rb will search for a "macos-"
-      // directory within the FlutterMacOS.xcframework, so create a dummy one.
-      Directory(
-        path.join(buildDir.path, 'FlutterMacOS.xcframework/macos-arm64_x86_64'),
-      ).createSync(recursive: true);
-
       // Clean before regenerating the config to ensure that the pod steps run.
       await inDirectory(Directory(app.rootPath), () async {
         await evalFlutter('clean');

diff --git a/packages/flutter_tools/bin/podhelper.rb b/packages/flutter_tools/bin/podhelper.rb
@@ -137,8 +137,8 @@ def flutter_additional_macos_build_settings(target)
   # This podhelper script is at $FLUTTER_ROOT/packages/flutter_tools/bin.
   # Add search paths from $FLUTTER_ROOT/bin/cache/artifacts/engine.
   artifacts_dir = File.join('..', '..', '..', '..', 'bin', 'cache', 'artifacts', 'engine')
-  debug_framework_dir = File.expand_path(File.join(artifacts_dir, 'darwin-x64', 'FlutterMacOS.xcframework'), __FILE__)
-  release_framework_dir = File.expand_path(File.join(artifacts_dir, 'darwin-x64-release', 'FlutterMacOS.xcframework'), __FILE__)
+  debug_framework_dir = File.expand_path(File.join(artifacts_dir, 'darwin-x64'), __FILE__)
+  release_framework_dir = File.expand_path(File.join(artifacts_dir, 'darwin-x64-release'), __FILE__)
   application_path = File.dirname(defined_in_file.realpath) if respond_to?(:defined_in_file)
   # Find the local engine path, if any.
   local_engine = application_path.nil? ?
@@ -156,17 +156,9 @@ def flutter_additional_macos_build_settings(target)
     # Skip other updates if it does not depend on Flutter (including transitive dependency)
     next unless depends_on_flutter(target, 'FlutterMacOS')
 
-    if local_engine
-      configuration_engine_dir = File.expand_path(File.join(local_engine, 'FlutterMacOS.xcframework'), __FILE__)
-    else
-      # Profile can't be derived from the CocoaPods build configuration. Use release framework (for linking only).
-      configuration_engine_dir = (build_configuration.type == :debug ? debug_framework_dir : release_framework_dir)
-    end
-    Dir.new(configuration_engine_dir).each_child do |xcframework_file|
-      if xcframework_file.start_with?('macos-') # Could be macos-arm64_x86_64, macos-arm64, macos-x86_64
-        build_configuration.build_settings['FRAMEWORK_SEARCH_PATHS'] = "\"#{configuration_engine_dir}/#{xcframework_file}\" $(inherited)"
-      end
-    end
+    # Profile can't be derived from the CocoaPods build configuration. Use release framework (for linking only).
+    configuration_engine_dir = local_engine || (build_configuration.type == :debug ? debug_framework_dir : release_framework_dir)
+    build_configuration.build_settings['FRAMEWORK_SEARCH_PATHS'] = "\"#{configuration_engine_dir}\" $(inherited)"
 
     # When deleted, the deployment version will inherit from the higher version derived from the 'Runner' target.
     # If the pod only supports a higher version, do not delete to correctly produce an error.

diff --git a/packages/flutter_tools/lib/src/artifacts.dart b/packages/flutter_tools/lib/src/artifacts.dart
@@ -25,7 +25,6 @@ enum Artifact {
   flutterXcframework,
   /// The framework directory of the macOS desktop.
   flutterMacOSFramework,
-  flutterMacOSXcframework,
   vmSnapshotData,
   isolateSnapshotData,
   icuData,
@@ -185,8 +184,6 @@ String? _artifactToFileName(Artifact artifact, Platform hostPlatform, [ BuildMod
       return 'Flutter.xcframework';
     case Artifact.flutterMacOSFramework:
       return 'FlutterMacOS.framework';
-    case Artifact.flutterMacOSXcframework:
-      return 'FlutterMacOS.xcframework';
     case Artifact.vmSnapshotData:
       return 'vm_isolate_snapshot.bin';
     case Artifact.isolateSnapshotData:
@@ -601,10 +598,6 @@ class CachedArtifacts implements Artifacts {
       final String engineDir = _getEngineArtifactsPath(platform, mode)!;
       return _fileSystem.path.join(engineDir, _artifactToFileName(artifact, _platform));
     }
-    if (platform != null && artifact == Artifact.flutterMacOSFramework) {
-      final String engineDir = _getEngineArtifactsPath(platform, mode)!;
-      return _getMacOSEngineArtifactPath(engineDir, _fileSystem, _platform);
-    }
     return _getHostArtifactPath(artifact, platform ?? _currentHostPlatform(_platform, _operatingSystemUtils), mode);
   }
 
@@ -624,7 +617,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.constFinder:
       case Artifact.flutterFramework:
       case Artifact.flutterMacOSFramework:
-      case Artifact.flutterMacOSXcframework:
       case Artifact.flutterPatchedSdkPath:
       case Artifact.flutterTester:
       case Artifact.flutterXcframework:
@@ -665,7 +657,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.frontendServerSnapshotForEngineDartSdk:
       case Artifact.constFinder:
       case Artifact.flutterMacOSFramework:
-      case Artifact.flutterMacOSXcframework:
       case Artifact.flutterPatchedSdkPath:
       case Artifact.flutterTester:
       case Artifact.fontSubset:
@@ -714,7 +705,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.constFinder:
       case Artifact.flutterFramework:
       case Artifact.flutterMacOSFramework:
-      case Artifact.flutterMacOSXcframework:
       case Artifact.flutterTester:
       case Artifact.flutterXcframework:
       case Artifact.fontSubset:
@@ -781,13 +771,6 @@ class CachedArtifacts implements Artifacts {
       case Artifact.engineDartAotRuntime:
         return _fileSystem.path.join(_dartSdkPath(_cache), 'bin', _artifactToFileName(artifact, _platform));
       case Artifact.flutterMacOSFramework:
-        String platformDirName = _enginePlatformDirectoryName(platform);
-        if (mode == BuildMode.profile || mode == BuildMode.release) {
-          platformDirName = '$platformDirName-${mode!.cliName}';
-        }
-        final String engineArtifactsPath = _cache.getArtifactDirectory('engine').path;
-        return _getMacOSEngineArtifactPath(_fileSystem.path.join(engineArtifactsPath, platformDirName), _fileSystem, _platform);
-      case Artifact.flutterMacOSXcframework:
       case Artifact.linuxDesktopPath:
       case Artifact.windowsDesktopPath:
       case Artifact.linuxHeaders:
@@ -913,33 +896,6 @@ String _getIosEngineArtifactPath(String engineDirectory,
       .path;
 }
 
-String _getMacOSEngineArtifactPath(
-  String engineDirectory,
-  FileSystem fileSystem,
-  Platform hostPlatform,
-) {
-  final Directory xcframeworkDirectory = fileSystem
-      .directory(engineDirectory)
-      .childDirectory(_artifactToFileName(Artifact.flutterMacOSXcframework, hostPlatform)!);
-
-  if (!xcframeworkDirectory.existsSync()) {
-    throwToolExit('No xcframework found at ${xcframeworkDirectory.path}. Try running "flutter precache --macos".');
-  }
-  final Directory? flutterFrameworkSource = xcframeworkDirectory
-      .listSync()
-      .whereType<Directory>()
-      .where((Directory platformDirectory) =>
-          platformDirectory.basename.startsWith('macos-'))
-      .firstOrNull;
-  if (flutterFrameworkSource == null) {
-    throwToolExit('No macOS frameworks found in ${xcframeworkDirectory.path}');
-  }
-
-  return flutterFrameworkSource
-      .childDirectory(_artifactToFileName(Artifact.flutterMacOSFramework, hostPlatform)!)
-      .path;
-}
-
 /// Manages the artifacts of a locally built engine.
 class CachedLocalEngineArtifacts implements Artifacts {
   CachedLocalEngineArtifacts(
@@ -1098,7 +1054,7 @@ class CachedLocalEngineArtifacts implements Artifacts {
         return _fileSystem.path.join(localEngineInfo.targetOutPath, 'gen', 'flutter', 'lib', 'snapshot', artifactFileName);
       case Artifact.icuData:
       case Artifact.flutterXcframework:
-      case Artifact.flutterMacOSXcframework:
+      case Artifact.flutterMacOSFramework:
         return _fileSystem.path.join(localEngineInfo.targetOutPath, artifactFileName);
       case Artifact.platformKernelDill:
         if (platform == TargetPlatform.fuchsia_x64 || platform == TargetPlatform.fuchsia_arm64) {
@@ -1110,9 +1066,6 @@ class CachedLocalEngineArtifacts implements Artifacts {
       case Artifact.flutterFramework:
         return _getIosEngineArtifactPath(
             localEngineInfo.targetOutPath, environmentType, _fileSystem, _platform);
-      case Artifact.flutterMacOSFramework:
-        return _getMacOSEngineArtifactPath(
-            localEngineInfo.targetOutPath, _fileSystem, _platform);
       case Artifact.flutterPatchedSdkPath:
         // When using local engine always use [BuildMode.debug] regardless of
         // what was specified in [mode] argument because local engine will
@@ -1293,7 +1246,6 @@ class CachedLocalWebSdkArtifacts implements Artifacts {
         case Artifact.flutterFramework:
         case Artifact.flutterXcframework:
         case Artifact.flutterMacOSFramework:
-        case Artifact.flutterMacOSXcframework:
         case Artifact.vmSnapshotData:
         case Artifact.isolateSnapshotData:
         case Artifact.icuData:

diff --git a/packages/flutter_tools/lib/src/build_system/targets/macos.dart b/packages/flutter_tools/lib/src/build_system/targets/macos.dart
@@ -157,7 +157,7 @@ class ReleaseUnpackMacOS extends UnpackMacOS {
   @override
   List<Source> get inputs => <Source>[
     ...super.inputs,
-    const Source.artifact(Artifact.flutterMacOSXcframework, mode: BuildMode.release),
+    const Source.artifact(Artifact.flutterMacOSFramework, mode: BuildMode.release),
   ];
 }
 
@@ -171,7 +171,7 @@ class ProfileUnpackMacOS extends UnpackMacOS {
   @override
   List<Source> get inputs => <Source>[
     ...super.inputs,
-    const Source.artifact(Artifact.flutterMacOSXcframework, mode: BuildMode.profile),
+    const Source.artifact(Artifact.flutterMacOSFramework, mode: BuildMode.profile),
   ];
 }
 
@@ -185,7 +185,7 @@ class DebugUnpackMacOS extends UnpackMacOS {
   @override
   List<Source> get inputs => <Source>[
     ...super.inputs,
-    const Source.artifact(Artifact.flutterMacOSXcframework, mode: BuildMode.debug),
+    const Source.artifact(Artifact.flutterMacOSFramework, mode: BuildMode.debug),
   ];
 }
 

diff --git a/packages/flutter_tools/lib/src/cache.dart b/packages/flutter_tools/lib/src/cache.dart
@@ -944,6 +944,14 @@ abstract class EngineCachedArtifact extends CachedArtifact {
       await artifactUpdater.downloadZipArchive('Downloading $friendlyName tools...', Uri.parse(url + urlPath), dir);
 
       _makeFilesExecutable(dir, operatingSystemUtils);
+
+      final File frameworkZip = fileSystem.file(fileSystem.path.join(dir.path, 'FlutterMacOS.framework.zip'));
+      if (frameworkZip.existsSync()) {
+        final Directory framework = fileSystem.directory(fileSystem.path.join(dir.path, 'FlutterMacOS.framework'));
+        ErrorHandlingFileSystem.deleteIfExists(framework, recursive: true);
+        framework.createSync();
+        operatingSystemUtils.unzip(frameworkZip, framework);
+      }
     }
 
     final File licenseSource = cache.getLicenseFile();

diff --git a/packages/flutter_tools/lib/src/commands/build_macos_framework.dart b/packages/flutter_tools/lib/src/commands/build_macos_framework.dart
@@ -4,7 +4,6 @@
 
 import 'package:meta/meta.dart';
 
-import '../artifacts.dart';
 import '../base/common.dart';
 import '../base/file_system.dart';
 import '../base/io.dart';
@@ -84,16 +83,13 @@ class BuildMacOSFrameworkCommand extends BuildFrameworkCommand {
 
       if (boolArg('cocoapods')) {
         produceFlutterPodspec(buildInfo.mode, modeDirectory, force: boolArg('force'));
-      } else {
-        await _produceFlutterFramework(buildInfo, modeDirectory);
       }
 
-      final Directory buildOutput = modeDirectory.childDirectory('macos');
-
-      // Build aot, create App.framework. Make XCFrameworks.
-      await _produceAppFramework(buildInfo, modeDirectory, buildOutput);
+      // Build aot, create App.framework and copy FlutterMacOS.framework. Make XCFrameworks.
+      await _produceAppFramework(buildInfo, modeDirectory);
 
       // Build and copy plugins.
+      final Directory buildOutput = modeDirectory.childDirectory('macos');
       await processPodsIfNeeded(project.macos, getMacOSBuildDirectory(), buildInfo.mode);
       if (boolArg('plugins') && hasPlugins(project)) {
         await _producePlugins(xcodeBuildConfiguration, buildOutput, modeDirectory);
@@ -204,15 +200,15 @@ end
   Future<void> _produceAppFramework(
     BuildInfo buildInfo,
     Directory outputBuildDirectory,
-    Directory macosBuildOutput,
   ) async {
     final Status status = globals.logger.startProgress(
-      ' ├─Building App.xcframework...',
+      ' ├─Building App.xcframework and FlutterMacOS.xcframework...',
     );
+
     try {
       final Environment environment = Environment(
         projectDir: globals.fs.currentDirectory,
-        outputDir: macosBuildOutput,
+        outputDir: outputBuildDirectory,
         buildDir: project.dartTool.childDirectory('flutter_build'),
         cacheDir: globals.cache.getRoot(),
         flutterRootDir: globals.fs.directory(Cache.flutterRoot),
@@ -255,45 +251,26 @@ end
       status.stop();
     }
 
-    final Directory appFramework = macosBuildOutput.childDirectory('App.framework');
+    final Directory appFramework = outputBuildDirectory.childDirectory('App.framework');
     await BuildFrameworkCommand.produceXCFramework(
       <Directory>[appFramework],
       'App',
       outputBuildDirectory,
       globals.processManager,
     );
     appFramework.deleteSync(recursive: true);
-  }
-
-  Future<void> _produceFlutterFramework(
-    BuildInfo buildInfo,
-    Directory modeDirectory,
-  ) async {
-    final Status status = globals.logger.startProgress(
-      ' ├─Copying FlutterMacOS.xcframework...',
-    );
-    final String engineCacheFlutterFrameworkDirectory = globals.artifacts!.getArtifactPath(
-      Artifact.flutterMacOSXcframework,
-      platform: TargetPlatform.darwin,
-      mode: buildInfo.mode,
-    );
-    final String flutterFrameworkFileName = globals.fs.path.basename(
-      engineCacheFlutterFrameworkDirectory,
-    );
-    final Directory flutterFrameworkCopy = modeDirectory.childDirectory(
-      flutterFrameworkFileName,
-    );
-
-    try {
-      // Copy xcframework engine cache framework to mode directory.
-      copyDirectory(
-        globals.fs.directory(engineCacheFlutterFrameworkDirectory),
-        flutterFrameworkCopy,
-        followLinks: false,
+    final Directory flutterFramework = outputBuildDirectory.childDirectory('FlutterMacOS.framework');
+
+    // If FlutterMacOS.podspec was generated, do not generate XCFramework.
+    if (!boolArg('cocoapods')) {
+      await BuildFrameworkCommand.produceXCFramework(
+        <Directory>[flutterFramework],
+        'FlutterMacOS',
+        outputBuildDirectory,
+        globals.processManager,
       );
-    } finally {
-      status.stop();
     }
+    flutterFramework.deleteSync(recursive: true);
   }
 
   Future<void> _producePlugins(

diff --git a/packages/flutter_tools/lib/src/flutter_cache.dart b/packages/flutter_tools/lib/src/flutter_cache.dart
@@ -858,12 +858,12 @@ List<List<String>> _getWindowsDesktopBinaryDirs(String arch) {
 }
 
 const List<List<String>> _macOSDesktopBinaryDirs = <List<String>>[
-  <String>['darwin-x64', 'darwin-x64/framework.zip'],
+  <String>['darwin-x64', 'darwin-x64/FlutterMacOS.framework.zip'],
   <String>['darwin-x64', 'darwin-x64/gen_snapshot.zip'],
-  <String>['darwin-x64-profile', 'darwin-x64-profile/framework.zip'],
+  <String>['darwin-x64-profile', 'darwin-x64-profile/FlutterMacOS.framework.zip'],
   <String>['darwin-x64-profile', 'darwin-x64-profile/artifacts.zip'],
   <String>['darwin-x64-profile', 'darwin-x64-profile/gen_snapshot.zip'],
-  <String>['darwin-x64-release', 'darwin-x64-release/framework.zip'],
+  <String>['darwin-x64-release', 'darwin-x64-release/FlutterMacOS.framework.zip'],
   <String>['darwin-x64-release', 'darwin-x64-release/artifacts.zip'],
   <String>['darwin-x64-release', 'darwin-x64-release/gen_snapshot.zip'],
 ];