Support for LZMA legacy images #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, but how closely was it adapted from squashfs-tools? We can't just reuse code because of a licensing difference. |
|
Inspiration came from here , although as there are certain steps to be taken and in certain order to decompress a given lzma buffer I don't see how it could be done differently. In anyway, I can change it to look in the way you'll fill comfortable. |
slaterd314
reviewed
Jan 25, 2020
vasi
reviewed
Feb 1, 2020
vasi
reviewed
Feb 1, 2020
vasi
reviewed
Feb 1, 2020
vasi
reviewed
Feb 1, 2020
vasi
reviewed
Feb 1, 2020
vasi
requested changes
Feb 1, 2020
|
Hey, do need to add more changes? |
|
I rebased this on the current main. All checks have passed and it appears that @vasi had no more objections, so I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.