Update CMakeLists.txt [Optional Installation]

[kenkit]

Optional Install.
This was was adding header files to my msi package

[vasild]

Hello,

Isn't not running make install sufficient? Why do you need to disable the install() CMake instructions?

https://cmake.org/cmake/help/latest/command/install.html

Rules specified by calls to this command within a source directory are executed in order during installation

Thanks!

[kenkit]

Sorry I couldn't respond sooner.
The install option is ambiguous in windows platform since it ends up adding the headers to cpack installation.
I found that most people make it optional or disabled on windows platform.
EDIT:I didn't disable it, I just made it optional

[vasild]

The install option is ambiguous in windows platform since it ends up adding the headers to cpack installation.

How do you install on Windows? Do you run cmake --install? What is puzzling me is that you disabled all install instructions and that is equivalent to just not running the install step, i.e. not installing, i.e. not running make install, cmake --install or whatever you do on Windows.

EDIT:I didn't disable it, I just made it optional

By default it gets disabled. I would merge this change, even though I do not understand the mechanics of installation on Windows (you help me understand that!). But can you revert the logic so that if you do nothing then, by default, the install works as before. And only if you define a variable (in the environment or on the cmake command line), then the install is skipped.

PS for consistency with the rest of the CMakeLists.txt use lowercase if() and endif().

Thanks!

[kenkit]

No. I use this package as a dependency in one of my projects.
My projects uses add_subdirectory in cmake and also uses the install option to install my projects files.
Since cpp-ipfs also calls install cmake will assume that the files in cpp-ipfs should also be installed.
Atleast two other projects I use have made the install optional e.g

https://github.com/libarchive/libarchive/blob/2f3033ca23f8c21160506c3c7ac8a0df0d3fde42/CMakeLists.txt#L224

I had made the pull request below,we removed the install option completely from windows as a result.

rikyoz/bit7z#27 (comment)

[kenkit]

Ok let me update the CMakeLists.txt

[kenkit]

Hi the failed test is not as a result of my changes.
All other tests seem to be fine.

[vasild]

Merged, thanks!