Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VM resource's power_state to be managed #278

Merged

Conversation

ddelnano
Copy link
Collaborator

@ddelnano ddelnano commented Oct 30, 2023

Summary: Allow VM resource's power_state to be managed

The VM resource's previous power_state attribute was computed and didn't allow for specifying the state as an input. This change implements the necessary support for creating VMs with a non default power_state and to manage the lifecycle of it as needed and completes #263.

Testing Done: The following checks were successful

  • New tests verifies that the new functionality works as expected for creating and updating VMs
  • Acceptance tests pass

Todo:

  • Clean up vm power state options (remove hardcoding) and remove bogus values ("Stopped" isn't a real state)
  • Add support for suspend and pause
  • Prevent destroy_cloud_config_vdi_after_boot = true and a non running power_state from being valid configuration

@ddelnano ddelnano force-pushed the update-power_state-to-be-non-computed-vm-resource-argument branch from 65c5089 to 39033f7 Compare December 28, 2023 08:39
@ddelnano ddelnano force-pushed the update-power_state-to-be-non-computed-vm-resource-argument branch from e3b78ae to d1b5061 Compare December 28, 2023 08:47
@ddelnano ddelnano merged commit 78b55ab into master Dec 28, 2023
3 checks passed
@ddelnano ddelnano deleted the update-power_state-to-be-non-computed-vm-resource-argument branch December 28, 2023 15:04
@ddelnano ddelnano added the enhancement New feature or request label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant