feat(@xen-orchestra/xapi): make nbd use configurable

vatesfr · Mar 15, 2023 · 9d6ec88 · 9d6ec88
1 parent f19d155
commit 9d6ec88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/@xen-orchestra/xapi/index.js b/@xen-orchestra/xapi/index.js
@@ -134,6 +134,7 @@ class Xapi extends Base {
   constructor({
     callRetryWhenTooManyPendingTasks = { delay: 5e3, tries: 10 },
     maxUncoalescedVdis,
+    preferNbd,
     syncHookSecret,
     syncHookTimeout,
     vdiDestroyRetryWhenInUse = { delay: 5e3, tries: 10 },
@@ -148,6 +149,7 @@ class Xapi extends Base {
     this._maxUncoalescedVdis = maxUncoalescedVdis
     this._syncHookSecret = syncHookSecret
     this._syncHookTimeout = syncHookTimeout
+    this._preferNbd = preferNbd
     this._vdiDestroyRetryWhenInUse = {
       ...vdiDestroyRetryWhenInUse,
       onRetry,

diff --git a/@xen-orchestra/xapi/vdi.js b/@xen-orchestra/xapi/vdi.js
@@ -62,7 +62,7 @@ class Vdi {
     })
   }
 
-  async exportContent(ref, { baseRef, cancelToken = CancelToken.none, format, preferNbd = true }) {
+  async exportContent(ref, { baseRef, cancelToken = CancelToken.none, format }) {
     const query = {
       format,
       vdi: ref,
@@ -72,7 +72,7 @@ class Vdi {
     }
     let nbdClient
     try {
-      if (preferNbd) {
+      if (this._preferNbd) {
         const nbdInfos = await this.call('VDI.get_nbd_info', ref)
         if (nbdInfos.length > 0) {
           // a little bit of randomization to spread the load

diff --git a/packages/xo-server/config.toml b/packages/xo-server/config.toml
@@ -178,6 +178,7 @@ vmSnapshotConcurrency = 2
 poolMarkingInterval = '6 hours'
 poolMarkingMaxAge = '48 hours'
 poolMarkingPrefix = 'xo:clientInfo:'
+preferNbd = true
 
 [xo-proxy]
 callTimeout = '1 min'