Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup: Health check - Unchecking does not stop health checks #6501

Closed
PieterWaegeman opened this issue Oct 31, 2022 · 4 comments · Fixed by #6515
Closed

Backup: Health check - Unchecking does not stop health checks #6501

PieterWaegeman opened this issue Oct 31, 2022 · 4 comments · Fixed by #6515

Comments

@PieterWaegeman
Copy link

In the backup schedule, when I enable "Health check", the next backup the health check runs. If I disable the option, the next backup the health check still runs.

To reproduce

  1. Make a backup job.
  2. Enable 'Health check" in the schedule.
  3. Run backup, wait for the backup to complete.
  4. Disable "Health check".
  5. Next backup, the health check is still performed while the option box is not checked. And no way to disable it.

Expected behavior
No health checks anymore when the box is not checked.

Environment (please provide the following information):

  • xo-server: 5.104.0
  • xo-web: 5.105.0
  • hypervisor: XCP-ng 8.2.1, latest patches to date
@julien-f
Copy link
Member

Changing the backup configuration will only impact the next run, not the current one.

It's very unlikely we'll change this behavior as it's not compatible with the current architecture and I believe the result would be surprising for users.

@PieterWaegeman
Copy link
Author

Yes. I know. The next run, the health checks are also performed while the option is disabled.
I already did 4 backup runs with the disabled option, but every time the health checks still run.

@julien-f
Copy link
Member

That sounds like a bug indeed, we'll investigate 🙂

@TristisOris
Copy link

topic about this bug. https://xcp-ng.org/forum/topic/6019/health-check/13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants